Proposal: standardized Subject state-peeking methods. #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to make sense. The additions to |
|
Due to the Experimental marking of these I'm being a little less stringent in discussing the addition to public APIs, but it seems to me that the precedent set on the BehaviorSubject shows the value of these methods. Additionally, Subjects are the stateful, side-effecting types and these methods seem to make sense for them. |
benjchristensen
added a commit
that referenced
this pull request
Apr 29, 2015
Proposal: standardized Subject state-peeking methods.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
Subjectclass to host the union of the state-peeking methods of the variousSubjectimplementations and fixes the inconsistent behavior ofReplaySubject.getValues(T[]).The changes enable the
SerializedSubjectto relay such state-peeking method calls into the wrapped subject and allows futureSubjectwrappers to do the same (#2458).