Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simpler naming in Action1, Func1 to assist IDEs #2866

Merged
merged 1 commit into from
Apr 9, 2015

Conversation

davidmoten
Copy link
Collaborator

Use simpler naming in Action1, Func1 because is used as a default for IDEs when generating implementing methods. For instance, in Eclipse when auto-generating the implementing methods for an Action1 I get by default:

new Action1<Integer>() {

    @Override
    public void call(Integer t1) {
         //TODO auto-generated
    }
}

I can't count the number of times I've removed the trailing 1 from the parameter before continuing and I'd appreciate not having to do it! (unfortunately I can't use Java 8 lambdas in all my code).

I'd also be open to a name other than t like value but would be happy just to see the 1 go.

@akarnokd
Copy link
Member

akarnokd commented Apr 9, 2015

👍

benjchristensen added a commit that referenced this pull request Apr 9, 2015
Use simpler naming in Action1, Func1 to assist IDEs
@benjchristensen benjchristensen merged commit afdad7f into ReactiveX:1.x Apr 9, 2015
@benjchristensen benjchristensen mentioned this pull request Apr 9, 2015
@davidmoten davidmoten deleted the Action1-argument-name branch April 10, 2015 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants