Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SizeEviction test needs to return false #2574

Merged
merged 1 commit into from
Jan 31, 2015
Merged

Conversation

jalandip
Copy link
Contributor

When a replay subject with size and time eviction policy is used then any observer that subscribes after some events are already pushed will not get those older events.
This is because if an observable is not yet terminated then on subscription by any new observer the check for event validity fails on the Size Eviction policy hence that event is dropped and not pushed to the new subscriber.

Relevant call stack:
{{{

 TimeOnAdd.call
     BoundedState.replayObserverFromIndexTest
        BoundedState.replayObserverFromIndexTest
             PairEvictionPolicy.test
}}}

Test Case:

  • add test case for this use case, Fails if without changes.

@akarnokd
Copy link
Member

Good catch. Thanks!

akarnokd added a commit that referenced this pull request Jan 31, 2015
SizeEviction test needs to return false
@akarnokd akarnokd merged commit ca02838 into ReactiveX:1.x Jan 31, 2015
@benjchristensen benjchristensen mentioned this pull request Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants