Add onBackpressureBuffer with capacity #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjchristensen this should fix the bug (it was in the test actually, which I was overcomplicating), it passes the full suite locally. I squashed the improvements you added earlier on the same commit, let me know if you prefer me to separate them. Thanks! |
The operator takes an optional capacity for the buffer and a callback that will be invoked if the buffer fills up, along with a MissingBackpressureException in the Observable's onError.
|
Thank you! (and this time all tests are passing so looks like it's all happy now). |
benjchristensen
added a commit
that referenced
this pull request
Dec 9, 2014
Add onBackpressureBuffer with capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator takes an optional capacity for the buffer and a callback
that will be invoked if the buffer fills up, along with a
MissingBackpressureException in the Observable's onError.