Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TrampolineScheduler NullPointerException #1736

Merged
merged 2 commits into from
Oct 10, 2014
Merged

Fix TrampolineScheduler NullPointerException #1736

merged 2 commits into from
Oct 10, 2014

Commits on Oct 9, 2014

  1. Fix TrampolineScheduler NullPointerException 

    I tried for about 30 minutes to replicate the NPE reported in ReactiveX#1702 but couldn't.
It makes sense reading the code that an unsubscribe could trigger an NPE though so I'm fixing it as per recommendation of @DylanSale even though I can't replicate.
I confirmed that the items are being put in the queue BEFORE the wip variable is incremented, so that concurrency seems okay.
    @benjchristensen
    benjchristensen committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    2cf4349 View commit details
    Browse the repository at this point in the history

  2. Remove use of ThreadLocal 

    This was an awkward leftover from early version of RxJava (pre v0.17).
    @benjchristensen
    benjchristensen committed Oct 9, 2014
    Configuration menu
    Copy the full SHA
    348ecce View commit details
    Browse the repository at this point in the history