Fix Merge: backpressure + scalarValueQueue don't play nicely #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g during request(..) when the last value emitted was from scalarValueQueue
This comment is no longer correct. 1420 was resolved.
The `wip` variable needs its access to be synchronized. Then it calls drainAndComplete outside the lock.
benjchristensen
added a commit
that referenced
this pull request
Oct 6, 2014
Fix Merge: backpressure + scalarValueQueue don't play nicely
|
RxJava is really useful so happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual merge of unit tests and fix by @dmgd for #1723
Thank you @dmgd for debugging this as
mergeis very complicated code (unfortunately).