Change repeatWhen and retryWhen signatures. #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…don't expose Notification<?>
|
LGTM |
jbripley
added a commit
to jbripley/RxScala
that referenced
this pull request
Oct 3, 2014
- If RxJava is updated with the same signature changes with ReactiveX/RxJava#1720, the conversion from RxScala to RxJava can be simplified, without any external signature changes in RxScala.
|
These public APIs seem better. Merging. |
benjchristensen
added a commit
that referenced
this pull request
Oct 4, 2014
Change repeatWhen and retryWhen signatures.
jbripley
added a commit
to jbripley/RxScala
that referenced
this pull request
Oct 11, 2014
- If RxJava is updated with the same signature changes with ReactiveX/RxJava#1720, the conversion from RxScala to RxJava can be simplified, without any external signature changes in RxScala.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shim to make it so the public api for repeatWhen and retryWhen don't expose Notification<?>
ReactiveX/RxScala#24