Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the sample list form constraint more generic #121

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

bvdmitri
Copy link
Member

Fix #117

@bvdmitri bvdmitri requested a review from albertpod May 30, 2023 06:23
@bvdmitri
Copy link
Member Author

Requires ReactiveBayes/ReactiveMP.jl#327

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.92 🎉

Comparison is base (7a4a5e6) 80.29% compared to head (2da94db) 81.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   80.29%   81.22%   +0.92%     
==========================================
  Files          11       11              
  Lines        1208     1209       +1     
==========================================
+ Hits          970      982      +12     
+ Misses        238      227      -11     
Impacted Files Coverage Δ
src/constraints/form/form_sample_list.jl 75.00% <50.00%> (+48.91%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@albertpod albertpod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bvdmitri bvdmitri merged commit 031a753 into main Jun 1, 2023
@bvdmitri bvdmitri deleted the dev-fix-sample-list-constraint branch June 1, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoProposal in the SampleListFormConstraints works only for univariate distributions and logpdfs
3 participants