Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ReactiveMP 3.9.0 #119

Merged
merged 3 commits into from
May 29, 2023
Merged

Migrate to ReactiveMP 3.9.0 #119

merged 3 commits into from
May 29, 2023

Conversation

bvdmitri
Copy link
Member

  • Flux is no longer needed for the CVI. Use Optimisers instead in tests.
  • Flux is still used in one of the examples

The CI most likely will fail unless a new release of ReactiveMP is merged in the General registry.

@bvdmitri bvdmitri requested a review from albertpod May 26, 2023 10:42
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bvdmitri
Copy link
Member Author

I'll restart the CI as soon as ReactiveMP 3.9.0 is released.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a4a5e6) 80.29% compared to head (811f413) 80.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   80.29%   80.29%           
=======================================
  Files          11       11           
  Lines        1208     1208           
=======================================
  Hits          970      970           
  Misses        238      238           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bvdmitri bvdmitri merged commit b692f5c into main May 29, 2023
@bvdmitri bvdmitri deleted the reactivemp-3.9.0 branch May 29, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants