Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poisson average energy computation #410

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix poisson average energy computation #410

merged 2 commits into from
Jul 23, 2024

Conversation

ismailsenoz
Copy link
Contributor

Average energy computation for Poisson node assumed samples are only positive. However, Poisson samples are non-negative. This PR fixes that by starting the average energy computation from 0.

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bvdmitri bvdmitri merged commit 92ca484 into main Jul 23, 2024
3 checks passed
@bvdmitri bvdmitri deleted the fix_poisson_ae branch July 23, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants