-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aromatic Training Reactions for Non-R-Addition Families #228
Conversation
4b9f8d8
to
4faee9a
Compare
Alright, all training reactions have been added. Here is the breakdown according to reaction family:
This PR is ready for review. |
4faee9a
to
8eb8482
Compare
8527fbb
to
4049eee
Compare
4049eee
to
241f463
Compare
241f463
to
c68cdf7
Compare
1c80117
to
23413ab
Compare
All appropriate changes are made from my end. |
23413ab
to
a620f27
Compare
I went ahead and fixed the conflict with the reaction family drawings, since I created the conflict by merging the files together. |
RMG-tests shows significant changes as a result of this branch. While this is not unexpected, I'm not sure how to ensure that these are acceptable differences. There are increases in time and memory across the board, but they are all due to additional species and reactions being found. The detailed differences can be found in the results.log file.
|
ccf6f51
to
a2576d9
Compare
I've given a quick read-through of the RMG-tests results to check for anything suspicious. Here's what I've come across. eg1: CH3 varied by more than 0.05 on average eg3 Other similar intra_H_migration reactions also have different kinetics, although the root cause is not as clear because estimate templates were used. Presumably new training reactions such as 117 above are the root cause of the change in kinetics. eg5 This mechanism has a lot of P-dep reactions, so it's difficult to trace back the origin of the discrepancy. eg6 This mechanism also has a lot of P-dep reactions, so it's difficult to trace back the origin of the discrepancy. eg7 NC solvent_hexane MCH There are a lot (~150) of non-overlapping reactions between the benchmark and test mechanisms. CC1CCCCC1 varied by more than 0.050 Conclusions |
Thanks for looking into this @zjburas! I'll take a look at the simulation profiles to see how much they differ. |
a2576d9
to
74daf9f
Compare
74daf9f
to
601db56
Compare
between a radical and either the meta or para position of a phenyl side group that is 1, 2, or 3 atoms away
TST calculated rates and for the the rates of the new aromatic-catalyzed 1,2-H shift pathway on this surface
Populated with training reactions from Mebel C6H5 + C4H4 PES.
in one step using Intra_R_Add_Exo_Scission family. No transition state was found.
To match reactions in C6H5_C4H4_all_TST_rates library
1,4_cyclic_birad_scission, intra_disprop, R_recombination, and 6_membered_central_C-C_shift to match reactions on C3H3 + C7H7 PES of 2012 Matsugi.
From a benzylic to a para-position on a benzene ring (and vice versa).
To better match new training reactions on C6H4C2H+C2H2 PES from 2016 Mebel calculations.
From chain to ring on phenyl+diacetylene adduct.
H_shift_to_single_resonant_radical_CPD, H_shift_to_double_resonant_radical_CPD, H_shift_to_single_resonant_radical_linear, H_shift_to_double_resonant_radical_linear. Now the radical can be on any types of atoms (R!H)
Intra_R_Add_Exo_scission
Training reactions index 85 through 117 added to intra_H_migration Data source from Wang, Villano, and Dean, "The Impact of Resonance Stabilization on the Intramolecular Hydrogen-Atom Shift Reactions of Hydrocarbon Radicals", ChemPhysChem, 2015. Few rules were used while adding training reactions: 1. Article reports A factors on a per hydrogen basis, as well as the number of possible hydrogen donors. All A-factors are multiplied by the number of hydrogens and degeneracy properly reported so that accurate rates are used in the event where an exact match takes place. 2. Symmetric reactions (with identical reactants and products) were reported with an A factor that is a factor of two slower in the source article, because of the symmetrical reaction coordinate around the transition state. All symmetric reaction rates have their A factors multiplied by 2. 3. Some reactants have identical resonance isomers. Reactions containing these reactants had their degeneracy and A factor multiplied by 2.
Groups added to circumvent training reactions from matching the same group
Also ensure spellings are consistent with the actual database
601db56
to
1a3e5d7
Compare
Added kinetic/forbidden groups and training reactions for aromatic reactions in #222 that fall under non-R-addition families (i.e., not R_Addition_MultipleBond, which is covered by #218 , and not Intra_R_Add_Exo/Endocyclic, which @mliu49 is figuring out what to do with). Most of the changes are to the intra_H_migration family, with some changes to other families such as R_recombination, Intra_ene and H_abs.
Also, added 2 new reaction families:
Intra_R_Add_Exo_Scission
1,2_ShiftC
I still have to actually add the training reactions, which will be done by tomorrow. Also, this PR partially takes the place of #207 .