Fix pressure dependence convergence issue with filterReactions on #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s added This applies to both in the case of filterReactions True AND False otherwise you can be stuck repeating enlargeEdge steps. This does not apply to the very initial enlargeEdge step after initial species
connie
added a commit
that referenced
this pull request
Feb 4, 2016
Fix pressure dependence convergence issue with filterReactions on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that similar pdep convergence problems occur when both pdep and filterReactions is on.
The
enlarge(reactEdge=True)step must be skipped in all cases where there are no new core species added, except for the very initial enlarge edge step after adding initial species.