Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax tolerances when testing HinderedRotor.get_enthalpy() #2457

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Relax tolerances when testing HinderedRotor.get_enthalpy() #2457

merged 1 commit into from
Jun 7, 2023

Commits on Jun 7, 2023

  1. Increase tolerance in test_get_enthalpy_quantum_fourier 

    When testing HinderedRotor.get_enthalpy() method using a Fourier series potential
 in the quantum limit it calls get_enthalpy
 which in the quantum limit calls solve_schrodinger_equation
 which calls scipy.linalg.eig_banded(H, lower=True, eigvals_only=True, overwrite_a_band=True)

 There's a lengthy discussion in #1682
 trying to track down the possibility of a bug.
In the end they increased the tolerance on a test.

Since nothing has changed recently, except some C libraries etc. on conda-forge,
I propose taking the same approach, and relaxing
the tolerance
    @rwest
    rwest committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    cd2b77a View commit details
    Browse the repository at this point in the history