Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse recipes should be in reverse order #1827

Closed
wants to merge 5 commits into from

Conversation

mazeau
Copy link
Contributor

@mazeau mazeau commented Nov 22, 2019

I found that when generating reverse templates, the action list would go in the same order as the forward, and this would cause issues when making and breaking multiple bonds.

    ['CHANGE_BOND', '*1', 1, '*2'],
    ['CHANGE_BOND', '*2', -1, '*3'],
    ['BREAK_BOND', '*2', 1, '*3'],
    ['FORM_BOND', '*3', 1, '*4'],
    ['CHANGE_BOND', '*3', 1, '*4']

This change fixes this template's reverse recipe.

@rwest
Copy link
Member

rwest commented Nov 23, 2019

Please can you make a PR from a dedicated topic branch so it just contains the changes described in the PR (in this case your commit "reverses the recipe actions for reverse templates" fb8ade7). Otherwise everything you do on your master ends up being added to this PR.
I think perhaps the only way to fix is to close this pull request and open a new one.

Ideally a topic branch pushed to the official fork (if you don't have permission to create branches there we can probably grant it), else one pushed to your fork but check the box to "Allow edits from maintainers")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants