Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Iodine as element in Chemkin input file #1825

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Added Iodine as element in Chemkin input file #1825

merged 1 commit into from
Dec 5, 2019

Conversation

sarahkha
Copy link
Member

Motivation or Problem

Adding Iodine in the elements section of the chemkin input file

Description of Changes

file chemkin.pyx in rmgpy folder.
s = 'ELEMENTS\n'

# map of isotope elements with chemkin-compatible element representation:
elements = ('H', ('H', 2), ('H', 3), 'C', ('C', 13), 'O', ('O', 18), 'N', 'Ne', 'Ar', 'He', 'Si', 'S', 'Cl', 'I')

Testing

A clear and concise description of testing that you've done or plan to do.

Reviewer Tips

Suggestions for verifying that this PR works or other notes for the reviewer.

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #1825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1825   +/-   ##
=======================================
  Coverage   43.02%   43.02%           
=======================================
  Files          80       80           
  Lines       21099    21099           
  Branches     5516     5516           
=======================================
  Hits         9077     9077           
+ Misses      11004    10990   -14     
- Partials     1018     1032   +14
Impacted Files Coverage Δ
arkane/kinetics.py 12.14% <0%> (ø) ⬆️
rmgpy/data/statmech.py 42.2% <0%> (ø) ⬆️
rmgpy/rmg/pdep.py 12.21% <0%> (ø) ⬆️
rmgpy/data/kinetics/database.py 50.61% <0%> (ø) ⬆️
rmgpy/data/kinetics/family.py 48.35% <0%> (ø) ⬆️
rmgpy/statmech/ndTorsions.py 59.78% <0%> (ø) ⬆️
rmgpy/yml.py 15.71% <0%> (ø) ⬆️
arkane/sensitivity.py 10% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a78cf...4083699. Read the comment docs.

Copy link
Member

@amarkpayne amarkpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, can you rebase?

@mliu49 mliu49 merged commit 5ffd38a into master Dec 5, 2019
@mliu49 mliu49 deleted the Iodine branch December 5, 2019 15:01
This was referenced Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants