Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WSL permisson bug for renaming directories #1796

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Fix WSL permisson bug for renaming directories #1796

merged 3 commits into from
Dec 10, 2019

Commits on Dec 10, 2019

  1. Fall back to copying dir if system call to rename fails for moving seed 

    WSL can occasionally throw permission errors when trying to rename non-empty directories, even when the user owns all of the files and directories.
    @amarkpayne
    amarkpayne committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    1b61342 View commit details
    Browse the repository at this point in the history

  2. Minor: remove unnecessary call to os.path.join in make_seed_mech

    @amarkpayne
    amarkpayne committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    21be711 View commit details
    Browse the repository at this point in the history

  3. Refactor first_time handling of saving the seed mechanism 

    Move all first_time only functions to a separate function that is called during the job initialization. This improves performance and readability
    @amarkpayne
    amarkpayne committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    5839d70 View commit details
    Browse the repository at this point in the history