-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename submodules in rmgpy.tools #1794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mliu49 Thanks for the contribution! I think it is a good idea to standardize the module names. The changes (using all-lowercase names) are according to PEP-8 nomenclature, right? @amarkpayne, your thoughts?
This is correct according to PEP-8 (https://www.python.org/dev/peps/pep-0008/#package-and-module-names). I think all of this looks good to go, but should we do the same for the scripts folder? The modules in the script folder are all consistent, but use a different convention. Rebase and I'll approve and merge |
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
==========================================
+ Coverage 42.92% 42.99% +0.06%
==========================================
Files 82 80 -2
Lines 21182 21090 -92
Branches 5519 5513 -6
==========================================
- Hits 9093 9067 -26
+ Misses 11074 11008 -66
Partials 1015 1015
Continue to review full report at Codecov.
|
Should be good to go once tests pass. |
Thanks for the PR @mliu49 ! |
Motivation or Problem
The submodules in the
tools
module are a bit of a mess in terms of naming. The 3.0 release seems like a good opportunity to rename them.Note that RMG-website imports will need to be updated, as will any other dependencies which use the tools module.
Description of Changes
Rename submodules in
rmgpy.tools
and update imports in RMG-Py.Test
.Reviewing
Any comments or suggestions about the new names are welcome.