Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several small Pdep bug fixes #1785

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Several small Pdep bug fixes #1785

merged 3 commits into from
Oct 30, 2019

Commits on Oct 30, 2019

  1. BugFix: Incorrect value assignment fixed in me.pyx

    @alongd
    alongd committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    4b2b6ef View commit details
    Browse the repository at this point in the history

  2. Don't raise an error if a YAML file does not have all pdep attributed 

    even if running a pdep job
These attributes can be given in the Arkane species file, and this check crushes Arkane before loading additional species parameters. If these parameters are indeed missing, Arkane will crush anyway downstream.
    @alongd
    alongd committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    baba248 View commit details
    Browse the repository at this point in the history

  3. PEP8 style change: eqRatios to eq_ratios in pdep/network.py 

    Also fixes a bug where in cse.pyx we assign `eq_ratios = network.eq_ratios` (it is now correct)
    @alongd
    alongd committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    c9c1d27 View commit details
    Browse the repository at this point in the history