Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Corrections to Arkane's Multidimensional Hindered Rotors docs #1784

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Oct 24, 2019

Arkane's documentation errors here. This PR fixes it.
Without an empty line between a text block and a table block, the table won't be auto-formatted. Also deleted a leading space in the text that Sphinx complained about, and fixed a table's header/bottom format.
Looked good when compiled locally.

@alongd alongd requested a review from mjohnson541 October 24, 2019 14:29
@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #1784 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   32.61%   32.61%           
=======================================
  Files          87       87           
  Lines       26124    26124           
  Branches     6878     6878           
=======================================
  Hits         8521     8521           
+ Misses      16644    16633   -11     
- Partials      959      970   +11
Impacted Files Coverage Δ
rmgpy/data/statmech.py 42.2% <0%> (ø) ⬆️
rmgpy/rmg/pdep.py 12.21% <0%> (ø) ⬆️
rmgpy/reaction.py 0% <0%> (ø) ⬆️
rmgpy/data/kinetics/family.py 48.35% <0%> (ø) ⬆️
rmgpy/yml.py 15.71% <0%> (ø) ⬆️
rmgpy/data/kinetics/database.py 50.61% <0%> (ø) ⬆️
rmgpy/rmg/input.py 34% <0%> (ø) ⬆️
rmgpy/molecule/molecule.py 0% <0%> (ø) ⬆️
rmgpy/statmech/ndTorsions.py 59.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2353f...b1c9736. Read the comment docs.

mjohnson541
mjohnson541 previously approved these changes Oct 28, 2019
@alongd
Copy link
Member Author

alongd commented Oct 28, 2019

@mjohnson541, could you re-approve and merge?

@alongd alongd self-assigned this Oct 29, 2019
mjohnson541
mjohnson541 previously approved these changes Oct 29, 2019
@mjohnson541
Copy link
Contributor

Sorry, can you rebase again?

Without an empty line between a text block and a table block, the table won't be auto-formatted. Also deleted a leading space in the text that Sphinx complained about. Also a table's header/bottom was fixed.
@alongd
Copy link
Member Author

alongd commented Oct 29, 2019

@mjohnson541, we're good to go

@mjohnson541 mjohnson541 merged commit be1de4b into master Oct 29, 2019
@mjohnson541 mjohnson541 deleted the nd_rot_doc branch October 29, 2019 19:27
@mliu49 mliu49 mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants