-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Corrections to Arkane's Multidimensional Hindered Rotors docs #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 87 87
Lines 26124 26124
Branches 6878 6878
=======================================
Hits 8521 8521
+ Misses 16644 16633 -11
- Partials 959 970 +11
Continue to review full report at Codecov.
|
mjohnson541
previously approved these changes
Oct 28, 2019
@mjohnson541, could you re-approve and merge? |
mjohnson541
previously approved these changes
Oct 29, 2019
Sorry, can you rebase again? |
Without an empty line between a text block and a table block, the table won't be auto-formatted. Also deleted a leading space in the text that Sphinx complained about. Also a table's header/bottom was fixed.
@mjohnson541, we're good to go |
mjohnson541
approved these changes
Oct 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arkane's documentation errors here. This PR fixes it.
Without an empty line between a text block and a table block, the table won't be auto-formatted. Also deleted a leading space in the text that Sphinx complained about, and fixed a table's header/bottom format.
Looked good when compiled locally.