-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atom index to Group()._repr_png_ #1758
Conversation
Out of curiosity, what happened with the other PR? |
I was trying to use the PR function in VScode but things didn't work the way I expected lol |
There is a unit test for the Group.draw method which you will need to update. |
unit test expected result modified |
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 87 87
Lines 26124 26124
Branches 6878 6878
=======================================
Hits 8521 8521
+ Misses 16644 16633 -11
- Partials 959 970 +11
Continue to review full report at Codecov.
|
Could you rebase? |
d4ad98f
to
1a23fd3
Compare
Rebase is finished. @mliu49 :-) |
Sorry, I forgot to merge this. Could you rebase again? |
1a23fd3
to
4fc5739
Compare
I rebased again. Thanks. |
4fc5739
to
ed87ab0
Compare
Description of Changes
Add atom index consistent with adjacency list to molecule group graph for users' convenience.