Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two calls to Exception.message, which no longer exists #1752

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Conversation

mliu49
Copy link
Contributor

@mliu49 mliu49 commented Oct 4, 2019

Motivation or Problem

Exceptions no longer have a message attribute. We fixed a bunch of cases already, but missed some.

Description of Changes

Replace calls to Exception.message with str(Exception).

Testing

These changes fixed the issues I was having. I don't know if it's necessary to do additional testing.

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@fcc4614). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1752   +/-   ##
=========================================
  Coverage          ?   32.61%           
=========================================
  Files             ?       87           
  Lines             ?    26103           
  Branches          ?     6869           
=========================================
  Hits              ?     8514           
  Misses            ?    16619           
  Partials          ?      970

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc4614...5566497. Read the comment docs.

@ajocher
Copy link
Contributor

ajocher commented Oct 7, 2019

Thanks for fixing. This looks fine to me and ready to be merged.

@ajocher ajocher merged commit 29e111d into master Oct 7, 2019
@mliu49
Copy link
Contributor Author

mliu49 commented Oct 7, 2019

Thanks!

@mliu49 mliu49 deleted the message branch November 22, 2019 20:25
@mliu49 mliu49 mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants