-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IPython notebooks #1735
Merged
Merged
Update IPython notebooks #1735
Commits on Oct 25, 2019
-
Remove Species import from rmgpy.molecule.draw
It was leading to circular imports, and was only used for an isinstance check, which was refactored
Configuration menu - View commit details
-
Copy full SHA for 44ab843 - Browse repository at this point
Copy the full SHA 44ab843View commit details -
Refactor entry sorting in kinetics rules
Main motivation is that None can no longer be compared to ints in Python 3 This changes how the sorting process is implemented but maintains the same behavior as before
Configuration menu - View commit details
-
Copy full SHA for 50ffd9e - Browse repository at this point
Copy the full SHA 50ffd9eView commit details -
Adjust reaction template retrieval when parsing reaction comments
In cases where there may have been a line break in the middle of the reaction template, which is very likely with automatically generated families.
Configuration menu - View commit details
-
Copy full SHA for b31cd43 - Browse repository at this point
Copy the full SHA b31cd43View commit details -
Configuration menu - View commit details
-
Copy full SHA for e30e430 - Browse repository at this point
Copy the full SHA e30e430View commit details -
Configuration menu - View commit details
-
Copy full SHA for 402e974 - Browse repository at this point
Copy the full SHA 402e974View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfb4268 - Browse repository at this point
Copy the full SHA cfb4268View commit details -
Configuration menu - View commit details
-
Copy full SHA for 355ada2 - Browse repository at this point
Copy the full SHA 355ada2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 216340f - Browse repository at this point
Copy the full SHA 216340fView commit details -
Fix get_labeled_reactants_and_products for new families
The R_Recombination family was changed for auto tree generation There is only a single template now, and duplicate * labels This copies template handling from __generate_reactions A unit test is also added
Configuration menu - View commit details
-
Copy full SHA for 8a057a4 - Browse repository at this point
Copy the full SHA 8a057a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.