Reduce the amount of logging messages that get too frequently printed during debug #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarkpayne
reviewed
Sep 13, 2019
There was a problem hiding this comment.
I talked with @mliu49 and we both agree that we can just get rid of this code instead of commenting it out. There are a couple of changes that need to be made due to the failing unit tests (at least one of them needs to be modified because it expects to see a logging statement that we are now getting rid of.
alongd
force-pushed
the
less_debug
branch
2 times, most recently
from
f546992 to
d123f68
Compare
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
- Coverage 32.6% 32.57% -0.03%
==========================================
Files 87 87
Lines 26115 26090 -25
Branches 6874 6866 -8
==========================================
- Hits 8514 8500 -14
+ Misses 16640 16616 -24
- Partials 961 974 +13
Continue to review full report at Codecov.
|
|
@amarkpayne, this PR should be ready for review now |
amarkpayne
approved these changes
Sep 27, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
When debugging RMG or a software that depends on RMG the amount of debugging statements that get printed jam the buffer, not allowing the developer to conveniently see the actual original error massage.
Description of Changes
Some logging statements, most of which are debugging level, were commented out. I only marked those which get printed too frequently in my experience. The purpose here was to flag them in the code for a discussion of how to best deal with them - leave commented out (so can be conveniently brought back to life if needed) or completely deleting them.
I think we can start the discussion even though we won't merge until the Py3 transition, since the same logging statements will be relevant after transitioning.