-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the instructions for running in parallel #1709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran superminimal and minimal examples with the updated documentation and both examples worked as expected with multiprocessing.
Please don't merge yet! I haven't decided exactly how we'll handle the PRs which have been opened since Py3 stuff started. |
Right. |
191a2c8
to
135d235
Compare
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
=======================================
Coverage 32.65% 32.65%
=======================================
Files 87 87
Lines 26158 26158
Branches 6874 6874
=======================================
Hits 8541 8541
+ Misses 16656 16645 -11
- Partials 961 972 +11
Continue to review full report at Codecov.
|
@ajocher if this looks good to you then you can merge this in as soon as the tests pass. |
@mliu49 I have also cherry-picked and pushed this to the |
The option `-n $Processes` is an argument to `rmg.py` not to `python`.
135d235
to
59bfa33
Compare
The option
-n $Processes
is an argument tormg.py
not topython
.Motivation or Problem
The documentation suggested
python -n $Processes path/to/rmg.py path/to/input.py
Description of Changes
It now says
python path/to/rmg.py -n $Processes path/to/input.py