Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page titles contain current release number instead of 2.1.0 #1680

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

rwest
Copy link
Member

@rwest rwest commented Aug 9, 2019

Pages currently have a title that's something like
<title>Arkane (arkane) &#8212; RMG-Py 2.1.0 Documentation</title>
which clearly we forget to update with new version numbers.
This should automatically update it with the release version.
The titles are not prominent in some browsers, but are very obvious in google search results etc.

…1.0 Documentation"

Pages currently have a title that's something like
`<title>Arkane (arkane) &#8212; RMG-Py 2.1.0 Documentation</title>`
which clearly we forget to update with new version numbers.
This should automatically update it with the release version.
Copy link
Contributor

@mliu49 mliu49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1680 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   41.79%   41.81%   +0.01%     
==========================================
  Files         177      177              
  Lines       30207    30207              
  Branches     6252     6252              
==========================================
+ Hits        12625    12630       +5     
+ Misses      16659    16655       -4     
+ Partials      923      922       -1
Impacted Files Coverage Δ
rmgpy/data/kinetics/family.py 48.91% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1029f90...6abadf9. Read the comment docs.

@mjohnson541 mjohnson541 merged commit 08c52ae into master Aug 9, 2019
@mjohnson541 mjohnson541 deleted the FixPageTitles branch August 9, 2019 19:50
@mliu49 mliu49 mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants