-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug with duplicate library reactions #1676
Conversation
I guess you guys already discussed it, but seems like we're misusing the family attribute. Also, won't that end in a weird comment in the mechanism file, such as |
The comments will be the same. It isn't exactly a misuse, LibraryReaction already had a family attribute that was identical to the original library, now the family attribute is the library it was loaded from. That doesn't exactly make it a clear solution to the problem, but it does make sense in context. |
19ff7f0
to
113dcfd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1676 +/- ##
==========================================
- Coverage 41.81% 41.81% -0.01%
==========================================
Files 177 177
Lines 30206 30207 +1
Branches 6252 6252
==========================================
Hits 12630 12630
- Misses 16654 16655 +1
Partials 922 922
Continue to review full report at Codecov.
|
For documentation purposes, the second commit is to address issues I've had with loading reaction libraries with the comment I think it's safer to only do the additional parsing for autoGenerated libraries. |
This sets the rxn.family attribute to the name of the library it was loaded from rather than the library it was originally from this prevents reactions in a seed mechanism that were originally from a reaction library from being duplicated if that reaction library is used as a reaction library or seed mechanism
bb03517
to
ac6162f
Compare
@alongd does this solve your issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes and explanations!
This sets the rxn.family attribute to the name of the library it was loaded from rather than the library it was originally from this prevents reactions in a seed mechanism that were originally from a reaction library from being duplicated if that reaction library is used as a reaction library or seed mechanism.