Check numpy version before passing rcond to numpy.linalg.lstsq #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
#1659 added the
rcond
argument to calls tonumpy.linalg.lstsq
. A side-effect is that we broke compatibility with numpy versions prior to 1.14.Original plan was to simply increase our numpy version requirement, but after thinking about it a bit more, this change does not seem like sufficient reason to do so.
Description of Changes
This PR adds automatic determination of the appropriate value for rcond depending on the numpy version.
It also updates and futurizes
utilities.py
.Testing
Will test in an environment with an older version of numpy. Travis should be sufficient to test that it works in newer versions of numpy.