Debug travis #1665
Merged
Debug travis #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarkpayne
added
Before Py3
Codecov Report
@@ Coverage Diff @@
## master #1665 +/- ##
=======================================
Coverage 41.68% 41.68%
=======================================
Files 176 176
Lines 29341 29341
Branches 6049 6049
=======================================
Hits 12232 12232
Misses 16239 16239
Partials 870 870Continue to review full report at Codecov.
|
|
See travis-ci/worker#604 for the issue we created with Travis on these problems |
|
You can rebase and I'll merge this. |
Prevents error when tests are run on computers with only 1 CPU
mliu49
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
A bug (well, at least we hope it is a bug and not a new feature) in Travis Worker 6.2.1 means that these builds only run with 1 CPU instead of the expected two. This made us realize that we have a bug in one of our unit tests that does not check the number of CPUs properly (fixed by this PR). We also want to display CPU and memory information in the Travis build log so that we can debug errors like this in the future.
While this PR will not fix Travis builds completely for 6.2.1 (there is no work around for insufficient memory) it fixes everything that we can right now, and we have opened up issues with Travis.
Description of Changes
Testing
I have already tested that our bug fixes work in Travis Worker 6.2.1, so we just need this to build in Travis Worker 6.2.0 so that we can merge this PR.