Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix nasa as dict #1630

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Bugfix nasa as dict #1630

merged 2 commits into from
Jun 25, 2019

Commits on Jun 25, 2019

  1. Get NASA.as_dict to ignore unset variables 

    Previously, NASA.as_dict would throw an error if attributes like
Tmin, Tmax, E0 were unset. These variables, however, are optional,
so Arkane should not crash if they are unset.

This commit fixes the as_dict method to not throw an error
for optional attributes
    @goldmanm
    goldmanm committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    4c6c95e View commit details
    Browse the repository at this point in the history

  2. Add tests to load species from NASA polynomials 

    This commit adds two test methods for NASA.as_dict and
two tests to load species from nasa polynomials in Arkane.

squash! Add tests to load species from NASA polynomials
    @goldmanm
    goldmanm committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    18a916f View commit details
    Browse the repository at this point in the history