Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In training notebook, save once per family instead of per reaction #1622

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

mliu49
Copy link
Contributor

@mliu49 mliu49 commented Jun 11, 2019

Now that saveTrainingReactions supports lists for metadata, this approach is much faster.

Now that saveTrainingReactions supports lists for metadata,
this approach is much faster.
@mliu49 mliu49 requested a review from jimchu10 June 11, 2019 21:17
@mliu49 mliu49 self-assigned this Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #1622 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage    41.5%   41.48%   -0.02%     
==========================================
  Files         176      176              
  Lines       29306    29306              
  Branches     6033     6033              
==========================================
- Hits        12163    12158       -5     
- Misses      16292    16296       +4     
- Partials      851      852       +1
Impacted Files Coverage Δ
rmgpy/data/kinetics/family.py 52.67% <0%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c81ea...d9e379d. Read the comment docs.

Copy link

@jimchu10 jimchu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the script successfully finished the task

@mliu49 mliu49 merged commit ed57a90 into master Jun 14, 2019
@mliu49 mliu49 deleted the save_training branch June 14, 2019 21:44
@mliu49 mliu49 mentioned this pull request Jun 14, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants