Modify test-database make target to not capture stdout and log #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are too many logging statements which get printed when the tests fail, and they aren't usually useful. This way, it's much easier to find the test output. Also change the other arguments to the long forms for clarity.
mliu49
added
Status: Ready for Review
|
@mjohnson541, could you please take a look and merge this? It will only take a minute. |
mjohnson541
approved these changes
May 17, 2019
|
Can you rebase? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
When database tests fail, you get a million lines of logging statements, making it a pain to find the actual test results.
Description of Changes
Disable log capturing for
make test-database.Testing
Break the database and try running the tests. A couple easy options: change an index in training reactions to be a duplicate or change a group definition to be more specific than its children.