-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error/warning messages concerning energy barriers in Arkane #1575
Conversation
Addresses #1574 |
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
======================================
Coverage 41.5% 41.5%
======================================
Files 176 176
Lines 29306 29306
Branches 6033 6033
======================================
Hits 12163 12163
Misses 16292 16292
Partials 851 851 Continue to review full report at Codecov.
|
The 1000/K axis is a pretty common convention to get the axis numbers into a more readily readable range, numbers in the ones or tenths digit instead of being in the thousandths digit and a bunch of leading zeros. The 1000/K axis is strangely artificial though and even though it makes the results more readable, it does not make them any more intelligible. Might I suggest instead adding a second axis, either in K or C? Something like what this link describes doing in Origin. Then you can keep either 1000/K or 1/K on the primary axis to keep the linearity of the Arrhenius plot, but the secondary axis makes it more easily understood which is probably your goal. http://blog.originlab.com/graphing/display-celsius-as-top-axis-in-arrhenius-plot |
Thanks for the suggestion, I agree it looks better to have a dual T axis. |
Oh I see! Yeah, having the units be 1000/K makes it ambiguous if the transform has already been done or done twice. Weird minor error. Carry on! |
@goldmanm, could you take a look? |
@goldmanm, could you take a look at this PR? |
`1000/K` is strange, should be either `1/K` or `K^-1`
arbitrarily chose 500 kJ/mol. Usually if this is triggered than the barrier is even much higher.
Added the barrier heights to the error message
@goldmanm, could you take a look at this PR? |
@alongd, I don't know how I missed the messages before. Looking at it now. |
Added a warning if a reaction barrier is too high in Arkane.
Also enhanced a related error message in tunnelling.
Minor: corrected reciprocal T axis units in Arkane plots (
1000/K
is strange, should be either1/K
orK^-1
)