Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move variable initiation to avoid undefined variable error #1546

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

mliu49
Copy link
Contributor

@mliu49 mliu49 commented Feb 3, 2019

Motivation or Problem

When using thermodynamic pruning, can encounter undefined variable error in processNewReactions().

Description of Changes

Move initiation of spcs variable earlier.

Testing

This input file crashes at 10 species without this fix. input.txt

@mliu49 mliu49 added Status: Ready for Review PR is complete and ready to be reviewed Complexity: Low Type: Bug labels Feb 3, 2019
@mliu49 mliu49 requested a review from mjohnson541 February 3, 2019 21:49
@mjohnson541
Copy link
Contributor

Looks good! Checks out!

@mjohnson541 mjohnson541 merged commit f4d8a0b into master Feb 3, 2019
@mjohnson541 mjohnson541 deleted the spcs_var branch February 3, 2019 23:39
@mliu49 mliu49 mentioned this pull request May 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Status: Ready for Review PR is complete and ready to be reviewed Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants