-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Explorer Part 2 #1545
Merged
Network Explorer Part 2 #1545
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6d4dd3e
make it possible to generate a network from a bimolecular reactant ch…
mjohnson541 e555121
make explore_tol a dimensionless scalar instead of a rate coefficient
mjohnson541 52bed57
fix bug with network molecular formula determination
mjohnson541 1ddfc39
use the sum of the rate coefficients for all net rates from the sourc…
mjohnson541 368f5e6
switch the methoxy example to using dimensionless explore_tol
mjohnson541 6c78949
update the documentation to reflect changes in the definition of expl…
mjohnson541 fa64d24
update the file used in explorerTest.py to use a valid explore_tol value
mjohnson541 6f39eb0
analyze multiple networks if generated initially
mjohnson541 55ce749
Add explorer example that involves a source channel with two reactant…
mjohnson541 87a330d
adjust the explorer tests so that they use explorerjob.networks inste…
mjohnson541 3f86bc2
separate explorer examples from network examples
mjohnson541 c9debc1
adapt running of all arkane examples as a functional test
mjohnson541 d580928
Write comments with thermo and reaction sources to Arkane pdep output…
mjohnson541 e09ad75
rename network.pdf's as they are made so they don't overwrite each other
mjohnson541 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -236,8 +236,7 @@ | |
|
||
explorer( | ||
source=['methoxy'], | ||
explore_tol=(1e-2,'s'), | ||
explore_tol=0.01, | ||
energy_tol=4.5e1, | ||
flux_tol=1e-10, | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check whether #1565 solved this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't solve the issue