Update RMG's ipython notebooks #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a fix for |
alongd
added
Module: Scripts
Complexity: Low
Type: Bug
Status: Help Needed
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
======================================
Coverage 41.6% 41.6%
======================================
Files 176 176
Lines 29142 29142
Branches 5990 5990
======================================
Hits 12125 12125
Misses 16173 16173
Partials 844 844Continue to review full report at Codecov.
|
5 tasks
|
I think can be rebased and merged, unless anyone else has comments. |
|
rebased |
mliu49
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
See #1533 - many of our notebooks currently crush when ran as provided
Description of Changes
Please choose a problematic notebook (either reported in #1533 or one that you know of) and fix it using this PR.
Testing
Someone should eventually run all our notebooks and verify they don't crush, and that they output what's expected of them.