-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-cat changes to master from cat branch, 1 #1538
Commits on Jan 31, 2019
-
Add a (failing) unit test for subgraph isomorphism checks of disjoint…
… graphs This is what's currently causing us a problem in RMG-Cat for van-der-Waals bonds, but this is a minimal test case to reproduce the problem in the vf2 algorithm. Unsure at this stage if it's reasonable to fix the vf2 algorithm or if we'll have to work around it at a higher level.
Configuration menu - View commit details
-
Copy full SHA for 3103b56 - Browse repository at this point
Copy the full SHA 3103b56View commit details -
Fix vf2 subgraph isomorphism for disconnected graphs.
If you have two graphs [1-2-3 4] and [1-2-3 4] then you can show they're isomorphic OK, but if you search for all the subgraph isomorphisms, it crashed. Now if there are no terminal atoms to choose from in, it chooses pairs only from non-matched vertices, instead of all vertices. I also added some commentary from the original paper.
Configuration menu - View commit details
-
Copy full SHA for f3641bb - Browse repository at this point
Copy the full SHA f3641bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b5e828 - Browse repository at this point
Copy the full SHA 7b5e828View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea502be - Browse repository at this point
Copy the full SHA ea502beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43d94c7 - Browse repository at this point
Copy the full SHA 43d94c7View commit details -
Improved error logging in Kinetics database when loading reaction fam…
…ilies. Replace print() statements with logging.error() when loading bad reaction families.
Configuration menu - View commit details
-
Copy full SHA for 686f300 - Browse repository at this point
Copy the full SHA 686f300View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37b8370 - Browse repository at this point
Copy the full SHA 37b8370View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59cee5c - Browse repository at this point
Copy the full SHA 59cee5cView commit details -
Move where a comment line is, I think to clarify.
Unless I misunderstood, I think this is clearer. (And if I did misunderstand, then it needs to be clearer!)
Configuration menu - View commit details
-
Copy full SHA for 8b499d1 - Browse repository at this point
Copy the full SHA 8b499d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e839e2 - Browse repository at this point
Copy the full SHA 8e839e2View commit details -
Create a getConversionFactorFromSItoCM method on Units.
The idea is that if the object has units of 'm^3/mol/s' then but you want to get it in chemkin format you need the value in 'cm^3/mol/s'. This gives the factor required. Add a warning in docstring about potential bug.
Configuration menu - View commit details
-
Copy full SHA for b9145c6 - Browse repository at this point
Copy the full SHA b9145c6View commit details -
Chemkin writing uses Units.getConversionFactorFromSItoCM()
This will allow us to do surface reactions with correct units. (Which will be implemented in a later commit) For gas-phase reactions, I put in a bunch of assert statements to check that the new implementation has the same effect as the old. If this is speed-critical code, they could be deprecated/removed.
Configuration menu - View commit details
-
Copy full SHA for ba9abca - Browse repository at this point
Copy the full SHA ba9abcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c7c183 - Browse repository at this point
Copy the full SHA 5c7c183View commit details -
Fix rate constant unit conversion to cm/mol/s
Replaced the method getConversionFactorFromSItoCM which used to leave things like Molecules in their original form, with a new method getConversionFactorFromSItoCmMolS which converts everything into S (apart from length becomes cm). This means that all chemkin files are now written in CM/MOL/S combinations even if the original rate was in m3/molecules/minute. A few reaction libraries and training rules are stored in molecules instead of moles, but the chemkin file must be consistent.
Configuration menu - View commit details
-
Copy full SHA for 4e58d65 - Browse repository at this point
Copy the full SHA 4e58d65View commit details -
Fix molecule drawing rotation bug. (master)
When rotating by matrix algebra, we need to keep self.coondinates and coordinates pointing to the same numpy array, otherwise other things that reference or update one will not see or change the other. This commit just does the non-cat instance, so can be applied to master branch.
Configuration menu - View commit details
-
Copy full SHA for 9e359a4 - Browse repository at this point
Copy the full SHA 9e359a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1eb8c - Browse repository at this point
Copy the full SHA 1c1eb8cView commit details -
Add cdef type declarations for base solver class
numSurfaceSpecies and numSurfaceReactions
Configuration menu - View commit details
-
Copy full SHA for f86e5d6 - Browse repository at this point
Copy the full SHA f86e5d6View commit details -
These don't seem to be catalyst-specific. (Though will be helpful for ones that are)
Configuration menu - View commit details
-
Copy full SHA for ad155a6 - Browse repository at this point
Copy the full SHA ad155a6View commit details -
Force simpleReactor initialization to use keyword arguments.
Reduces the chances of passing the wrong thing by using positional arguments.
Configuration menu - View commit details
-
Copy full SHA for bdec0ff - Browse repository at this point
Copy the full SHA bdec0ffView commit details -
Test the A-factor units on reaction library kinetics.
So far this does: - Arrhenius - Third Body - Falloff (Lindemann, Troe) - PDepArrhenius (PLOG) - MultiArrhenius - MultiPDepArrhenius in reaction libraries. This could also be done for other instances of kinetics (training depositories, etc.)
Configuration menu - View commit details
-
Copy full SHA for b0696fc - Browse repository at this point
Copy the full SHA b0696fcView commit details -
Add units check for kinetics depositories to database test
Make checkLibraryRateUnits more generic Add test definition for kinetics depositories
Configuration menu - View commit details
-
Copy full SHA for e1f4e4b - Browse repository at this point
Copy the full SHA e1f4e4bView commit details