Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set KERAS_BACKEND=theano before importing DDE #1535

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Conversation

mliu49
Copy link
Contributor

@mliu49 mliu49 commented Jan 18, 2019

Motivation or Problem

This ensures that the keras backend is set to theano so that dde works properly, regardless of the environment variables set originally. Fixes #1532.

Description of Changes

Change the KERAS_BACKEND environment variable using os.environ.

Testing

Should be tested on mac:

  • Activate rmg_env
  • Check echo $KERAS_BACKEND, should be tensorflow
  • Verify that make test passes

Because DDE only works with theano, this avoids any issues
with having this environment variable improperly set
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #1535 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1535      +/-   ##
==========================================
+ Coverage   42.06%   42.07%   +<.01%     
==========================================
  Files         165      165              
  Lines       27823    27824       +1     
  Branches     5668     5668              
==========================================
+ Hits        11705    11706       +1     
  Misses      15332    15332              
  Partials      786      786
Impacted Files Coverage Δ
rmgpy/ml/estimator.py 97.56% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867f57a...86e580f. Read the comment docs.

@mjohnson541 mjohnson541 merged commit fb10a7b into master Jan 18, 2019
@mjohnson541 mjohnson541 deleted the keras_backend branch January 18, 2019 21:36
@mliu49 mliu49 mentioned this pull request May 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants