Minor: Modified saving proceedure of species_dictionary.txt in Arkane #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only create the file if the species has a structure
Codecov Report
@@ Coverage Diff @@
## master #1528 +/- ##
=======================================
Coverage 42.08% 42.08%
=======================================
Files 165 165
Lines 27823 27823
Branches 5668 5668
=======================================
Hits 11710 11710
Misses 15328 15328
Partials 785 785Continue to review full report at Codecov.
|
goldmanm
approved these changes
Jan 8, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only create the
species_dictionary.txtfile if the species has a structure. This avoids generating empty and suspiciousspecies_dictionary.txtfiles.