Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing monoatomic species in Arkane/molpro #1521

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Processing monoatomic species in Arkane/molpro #1521

merged 2 commits into from
Jan 3, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Dec 14, 2018

Minor fixes allowing Arkane to process monoatomic species (atoms) calculated using molpro.
An example for an atom sp job output:
output.txt

Specifically we care about parsing the following part:

 Point group  D2h 



 ATOMIC COORDINATES

 NR  ATOM    CHARGE       X              Y              Z

   1  H       1.00    0.000000000    0.000000000    0.000000000

 NUCLEAR CHARGE:                    1
 NUMBER OF PRIMITIVE AOS:          21

@alongd alongd added the Arkane label Dec 14, 2018
@alongd alongd self-assigned this Dec 14, 2018
@alongd alongd requested a review from goldmanm December 14, 2018 15:03
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #1521 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
+ Coverage   42.06%   42.08%   +0.01%     
==========================================
  Files         165      165              
  Lines       27823    27823              
  Branches     5668     5668              
==========================================
+ Hits        11705    11710       +5     
+ Misses      15332    15328       -4     
+ Partials      786      785       -1
Impacted Files Coverage Δ
rmgpy/data/kinetics/family.py 58.58% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70bd44...bf04302. Read the comment docs.

@alongd alongd force-pushed the mp_coord branch 3 times, most recently from ace3d54 to 58d6948 Compare December 20, 2018 00:45
@alongd
Copy link
Member Author

alongd commented Jan 3, 2019

@goldmanm, could you take a look?

@goldmanm
Copy link
Contributor

goldmanm commented Jan 3, 2019

Yup. I'll look at it tomorrow morning.

@goldmanm goldmanm merged commit 99f712f into master Jan 3, 2019
@goldmanm goldmanm deleted the mp_coord branch January 3, 2019 15:18
@mliu49 mliu49 mentioned this pull request May 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants