Skip to content

Commit

Permalink
Force simpleReactor initialization to use keyword arguments.
Browse files Browse the repository at this point in the history
Reduces the chances of passing the wrong thing by using
positional arguments.
  • Loading branch information
rwest committed Jan 25, 2019
1 parent 71a2db6 commit 15b2c07
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions rmgpy/solver/simple.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,10 @@ cdef class SimpleReactor(ReactionSystem):

# First call the base class version of the method
# This initializes the attributes declared in the base class
ReactionSystem.initializeModel(self, coreSpecies, coreReactions, edgeSpecies, edgeReactions,
surfaceSpecies=surfaceSpecies, surfaceReactions=surfaceReactions,
pdepNetworks=pdepNetworks, atol=atol, rtol=rtol,
sensitivity=sensitivity, sens_atol=sens_atol, sens_rtol=sens_rtol,
filterReactions=filterReactions, conditions=conditions)
ReactionSystem.initializeModel(self, coreSpecies=coreSpecies, coreReactions=coreReactions, edgeSpecies=edgeSpecies,
edgeReactions=edgeReactions, surfaceSpecies=surfaceSpecies, surfaceReactions=surfaceReactions,
pdepNetworks=pdepNetworks, atol=atol, rtol=rtol, sensitivity=sensitivity, sens_atol=sens_atol,
sens_rtol=sens_rtol, filterReactions=filterReactions, conditions=conditions)

# Set initial conditions
self.set_initial_conditions()
Expand Down

0 comments on commit 15b2c07

Please sign in to comment.