Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Arkane logs imports #255

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Updated Arkane logs imports #255

merged 1 commit into from
Nov 22, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Nov 22, 2019

To comply with recent changes to Arkane (ReactionMechanismGenerator/RMG-Py#1788)

To comply with recent changes to Arkane
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files          29       29           
  Lines        8862     8862           
  Branches     2582     2582           
=======================================
  Hits         4199     4199           
+ Misses       4004     3996    -8     
- Partials      659      667    +8
Impacted Files Coverage Δ
arc/parser.py 82.74% <100%> (ø) ⬆️
arc/common.py 85.08% <100%> (ø) ⬆️
arc/reaction.py 38.56% <0%> (ø) ⬆️
arc/scheduler.py 17.78% <0%> (ø) ⬆️
arc/processor.py 52.36% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff6712...6e965ff. Read the comment docs.

@alongd alongd merged commit 568e6c6 into master Nov 22, 2019
@alongd alongd deleted the arkane_logs branch November 22, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant