New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename missleading name #31

Merged

doranteseduardo merged 1 commit into ReactVision:main from hannesa2:RenameMissleadingName

Oct 1, 2021

Collaborator

hannesa2 commented Sep 25, 2021 •

edited

Loading

Your shared code has currently the name app, this is in my point of view confusing.

In an upcoming pull request I'll move samples into render project. This will help to see all in Android Studio in a single project,

Advantages:

to have a better overview
easier to test
easier to apply changes to sample(s)

Doing this, the module app is misleading. Now it has the new name sharedCode.

And ok, it's "just" a rename but it causes a lot of file changes. -sorry-
But that's why I introduced a CI


          Rename missleading name

5d70db4

doranteseduardo merged commit 1c6c440 into ReactVision:main

hannesa2 deleted the RenameMissleadingName branch

October 2, 2021 05:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet