Skip to content

Commit

Permalink
Remove API keys
Browse files Browse the repository at this point in the history
  • Loading branch information
robertjcolley committed Feb 19, 2024
1 parent b8c28f0 commit e5a9f99
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 16 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
- name: set up JDK
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: 11
distribution: "adopt"
java-version: 17

- name: assemble ViroCore
run: |
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: "adopt"
java-version: 11
java-version: 17
- name: Code checks
run: ./gradlew check
- name: Archive Lint report
Expand All @@ -62,8 +62,8 @@ jobs:
strategy:
fail-fast: false
matrix:
xcode: [ '12.5.1', '13.2.1' ]
macOS: [ 'macOS-11' ]
xcode: ["12.5.1", "13.2.1"]
macOS: ["macOS-11"]
steps:
- uses: actions/checkout@v3.3.0
- name: Install gpg
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release with changelog
on:
push:
tags:
- '*'
- "*"

jobs:
release:
Expand All @@ -17,14 +17,14 @@ jobs:
- name: Install JDK ${{ matrix.java_version }}
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: 11
distribution: "adopt"
java-version: 17

- name: Get the version
id: tagger
uses: jimschubert/query-tag-action@v2
with:
skip-unshallow: 'true'
skip-unshallow: "true"
abbrev: false
commit-ish: HEAD

Expand Down Expand Up @@ -60,4 +60,4 @@ jobs:
./virocore/build/outputs/aar/virocore-release.aar
./sharedCode/build/outputs/aar/sharedCode-release.aar
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3 changes: 0 additions & 3 deletions android/releasetest/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
</intent-filter>
</activity>
<meta-data android:name="com.google.ar.core" android:value="optional" />
<meta-data
android:name="com.google.android.ar.API_KEY"
android:value="AIzaSyCZy6wqu20yo-r6mUCne3KH0YrR18mP2QI" />
</application>

</manifest>
3 changes: 0 additions & 3 deletions android/renderertest/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@
<meta-data
android:name="com.google.ar.core"
android:value="optional" />
<meta-data
android:name="com.google.android.ar.API_KEY"
android:value="AIzaSyCZy6wqu20yo-r6mUCne3KH0YrR18mP2QI" />

<activity
android:name="com.viromedia.renderertest.ViroActivity"
Expand Down

0 comments on commit e5a9f99

Please sign in to comment.