Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example urls in READMEs #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: example urls in READMEs #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ARDrivingCar/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# AR Driving Car

Adapted from original code from here:
https://github.com/viromedia/viro/tree/master/js/ARDrivingCarDemo
Adapted from original code from here:
https://github.com/viromedia/viro/tree/master/code-samples/js/ARDrivingCarDemo

## Installation

Expand All @@ -18,4 +18,4 @@ NOTE: The variant arguments are not needed for debug or release.
Mulit-touch is not working on Android, so you can't control the steering wheel and the pedals at the same time.

Also has a yellow console warning:
Warning: Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.
Warning: Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.
5 changes: 2 additions & 3 deletions ARReticle/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

Example code for using a reticle for object placement. The reticle is a quad in the center of the field of view which uses camera hit testing to find the horizontal plane. Press the reticle to place the object.

Adapted from original code from here:
https://github.com/viromedia/viro/tree/master/js/ARDrivingCarDemo
Adapted from original code from here:
https://github.com/viromedia/viro/tree/master/code-samples/js/ARDrivingCarDemo

## Installation

Expand All @@ -14,4 +14,3 @@ https://github.com/viromedia/viro/tree/master/js/ARDrivingCarDemo
5. `npx react-native run-android` or `npx react-native run-ios`

NOTE: The variant arguments are not needed for debug or release.