Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prop-types package instead of React.PropTypes #287

Merged
merged 2 commits into from
Apr 14, 2017

Conversation

ssilve1989
Copy link
Contributor

In response to warnings appearing when using React 15.5+

@@ -43,7 +43,8 @@
"react-dom": "^0.14.0 || ^15.0.0"
},
"dependencies": {
"classnames": "^2.2.0"
"classnames": "^2.2.0",
"prop-types": "^15.5.8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be under devDependencies

@ssilve1989
Copy link
Contributor Author

ssilve1989 commented Apr 13, 2017

@audiolion
Actually its suggested to place it in dependencies.

A quote from the library page.

For libraries, we also recommend leaving it in dependencies:

  "dependencies": {
    "prop-types": "^15.5.0" 
  },
  "peerDependencies": {
    "react": "^15.5.0" 
  }

https://www.npmjs.com/package/prop-types

Copy link

@audiolion audiolion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, well ya got me 👍

@wwayne
Copy link
Collaborator

wwayne commented Apr 14, 2017

Yeah thanks @ssilve1989 and @audiolion , merging

@wwayne wwayne merged commit 7390730 into ReactTooltip:master Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants