Fixes IE bug when empty data-tip. #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to see the bug: 1. Create two elements with data-tip attribute 2. Add content to one of the data-tip attributes, and have en empty string in the other 3. Hover over the one with content 4. Exit the element 5. Hover over the one without content Result: An empty tooltip will appear in IE 10 and 11 (probably others as well) If exit the element without content, then enter again, all is ok. Probable reason: Since the content of the tooltip is not reset after exit, some logic probably thinks there is content, even though the new item does not have content.
|
Thanks for exploring the problem, but I found it's little more complicated than what we thought. For example, the problem would be still there if we are using Finally I add a new state Anyway, thanks for your findings and PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to see the bug:
Result:
An empty tooltip will appear in IE 10 and 11 (probably others as well)
If exit the element without content, then enter again, all is ok.
Probable reason:
Since the content of the tooltip is not reset after exit, some logic probably thinks there is content, even though the new item does not have content.