Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove anchor when data-tooltip-id gets changed #1153

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix: remove anchor when data-tooltip-id gets changed #1153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@ const Tooltip = ({
const newId = (mutation.target as HTMLElement).getAttribute('data-tooltip-id')
if (newId === id) {
newAnchors.push(mutation.target as HTMLElement)
} else if (mutation.oldValue === id) {
// data-tooltip-id has now been changed, so we need to remove this anchor
removedAnchors.push(mutation.target as HTMLElement)
}
}
if (mutation.type !== 'childList') {
Expand Down Expand Up @@ -727,6 +730,8 @@ const Tooltip = ({
subtree: true,
attributes: true,
attributeFilter: ['data-tooltip-id'],
// to track the prev value if we need to remove anchor when data-tooltip-id gets changed
attributeOldValue: true,
})
return () => {
documentObserver.disconnect()
Expand Down
Loading