Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YouTube - Hide ads): Add Hide end screen store banner #4351

Merged
merged 10 commits into from
Jan 27, 2025
Merged

feat(YouTube - Hide ads): Add Hide end screen store banner #4351

merged 10 commits into from
Jan 27, 2025
+65 −39

Conversation

ILoveOpenSourceApplications
Copy link
Contributor

Closes #4349. Updated a few strings while I was at it to make things a bit more consistent.

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube - Hide ads):Add Hide end screen store ad feat(YouTube - Hide ads): Add Hide end screen store ad Jan 24, 2025
@ILoveOpenSourceApplications
Copy link
Contributor Author

I just had Visit store button reappear for me with the new path being page_header.eml. Should I open a new PR or simple add it to the filter. More details here in this #3058 (comment).

@LisoUseInAIKyrios
Copy link
Contributor

Make another pull request so the chang logs are more clear.

@ILoveOpenSourceApplications
Copy link
Contributor Author

@oSumAtrIX, do you have any suggestion as to where to keep this setting? It makes sense to be inside ads, but something in ads section being off out of the box also feels odd to me. Any suggestions?

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Jan 25, 2025 that may be closed by this pull request
feat(YouTube - Hide ads): Hide end screen store banner #4349
Closed
3 tasks
@ILoveOpenSourceApplications
Copy link
Contributor Author

Alternatively, this can also be called Hide view store banner as there is a view button which when clicked takes the user to the store tab in the channel page.

@LisoUseInAIKyrios
Copy link
Contributor

Or maybe Hide end screen store banner since it only applies to the end screen and nowhere else.

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title feat(YouTube - Hide ads): Add Hide end screen store ad feat(YouTube - Hide ads): Add Hide end screen store banner Jan 25, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios removed the request for review from oSumAtrIX January 27, 2025 08:25
@LisoUseInAIKyrios
Copy link
Contributor

To reduce the changes creeping out of scope I reverted the string changes that remove quotes.

Any other string changes can be done in another PR if really desired.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 5505087 into ReVanced:dev Jan 27, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
@semantic-release-bot
chore: Release v5.10.0-dev.3 [skip ci]
440b41f 
# [5.10.0-dev.3](v5.10.0-dev.2...v5.10.0-dev.3) (2025-01-27)

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([#4351](#4351)) ([5505087](5505087))
@ILoveOpenSourceApplications ILoveOpenSourceApplications deleted the feat/hide-end-screen-ad branch January 27, 2025 09:31
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
@semantic-release-bot
chore: Release v5.10.0-dev.1 [skip ci]
11de38e 
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
@semantic-release-bot
chore: Release v5.10.0-dev.1 [skip ci]
1459735 
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 27, 2025
@semantic-release-bot
chore: Release v5.10.0-dev.1 [skip ci]
7409f65 
# [5.10.0-dev.1](v5.9.0...v5.10.0-dev.1) (2025-01-27)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
@inotia00 inotia00 mentioned this pull request Jan 28, 2025
Merged
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore: Release v5.10.0 [skip ci]
a5c32ec 
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore: Release v5.10.0 [skip ci]
0c27f1b 
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore: Release v5.10.0 [skip ci]
c4d3551 
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
github-actions bot pushed a commit to notmarek/revanced-patches that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore: Release v5.10.0 [skip ci]
920273e 
# [5.10.0](v5.9.0...v5.10.0) (2025-01-28)

### Bug Fixes

* **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4341](https://github.com/notmarek/revanced-patches/issues/4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([ReVanced#4333](https://github.com/notmarek/revanced-patches/issues/4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([ReVanced#4329](https://github.com/notmarek/revanced-patches/issues/4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([ReVanced#4351](https://github.com/notmarek/revanced-patches/issues/4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([ReVanced#4355](https://github.com/notmarek/revanced-patches/issues/4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([ReVanced#4337](https://github.com/notmarek/revanced-patches/issues/4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([ReVanced#4347](https://github.com/notmarek/revanced-patches/issues/4347)) ([0528f7c](0528f7c))
@LisoUseInAIKyrios LisoUseInAIKyrios mentioned this pull request Jan 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
@semantic-release-bot
chore: Release v5.10.0 [skip ci]
226f40d 
# [5.10.0](v5.9.0...v5.10.0) (2025-01-31)

### Bug Fixes

* **SwissId - Play integrity Removal:** Add recommended app version ([#4370](#4370)) ([d8ed474](d8ed474))
* Use correct path to fix invalid file paths ([5ff4ee8](5ff4ee8))
* **YouTube - Hide ads:** fix 'Hide the Visit store button on channel pages' not working ([#4364](#4364)) ([9d63ea9](9d63ea9))
* **YouTube - Hide Ads:** Hide end screen store banner without leaving empty space ([#4367](#4367)) ([7e68390](7e68390))
* **YouTube - Hide ads:** Hide new types of tablet ads ([574bcc8](574bcc8))
* **YouTube - Hide layout components:** Hide new kind of community post ([#4341](#4341)) ([02685c4](02685c4))
* **YouTube - Hide seekbar:** Do not hide player seekbar if hide feed seekbar is enabled ([#4333](#4333)) ([f5cf6f2](f5cf6f2))
* **YouTube - Hide video description components:** Use correct string key names ([0f28c2b](0f28c2b))
* **YouTube - Spoof video streams:** Update settings side effects summary text ([#4369](#4369)) ([e5b3aa1](e5b3aa1))
* **YouTube - Theme:** Fix 19.25 - 19.45 patch error ([5b47a5f](5b47a5f))
* **YouTube - Theme:** Replace custom seekbar gradient colors instead of disabling ([#4329](#4329)) ([f03da98](f03da98))

### Features

* **YouTube - Hide ads:** Add `Hide end screen store banner` ([#4351](#4351)) ([5505087](5505087))
* **YouTube - Hide video description components:** Add `Hide How this content was made section` ([#4355](#4355)) ([68ec54e](68ec54e))
* **YouTube - Theme:** Add option to use custom seekbar accent color ([#4337](#4337)) ([952b4fc](952b4fc))
* **YouTube:** Add patch `Disable HDR video` ([#4347](#4347)) ([0528f7c](0528f7c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(YouTube - Hide ads): Hide end screen store banner
2 participants
@ILoveOpenSourceApplications @LisoUseInAIKyrios