Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal helpers which generate fragmented messages #6534

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

MichaelChirico
Copy link
Member

Noted in #6532. We should also address the group.desc issue, but in principle this PR could be submitted first. cc @aitap

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Comparison Plot

Generated via commit 93cfd19

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 3 minutes and 30 seconds

Time taken to run atime::atime_pkg on the tests: 9 minutes and 21 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helper function duplicated_values looks ok.
I think we should remove group.desc argument, and add a new argument, called.from.measure default FALSE.

  • If TRUE then we use stopf("... arguments to measure should be uniquely named, problems: %s")
  • If FALSE then we use stopf("elements of fun.list should be uniquely named, problems: %s")
    or is there some better way of handling the translation issue?

@MichaelChirico
Copy link
Member Author

I went with "just drop group.desc altogether", I think the error will be clear enough. measurev() is mentioned, which is documented next to measure() with the argument fun.list. If we really wanted to keep the distinction, I'd suggest looking at sys.calls() or something like that, rather than adding a new argument which is kind of useless when measurev() is exported.

@tdhock
Copy link
Member

tdhock commented Sep 24, 2024

yes that is a good point that we shouldn't be adding arguments that the user can not provide

@MichaelChirico
Copy link
Member Author

OK, I'll merge here. If we decide to decide internally that parent is ... and change the message, we can do so as a follow-up :)

@MichaelChirico MichaelChirico merged commit 960ff28 into master Sep 24, 2024
8 checks passed
@MichaelChirico MichaelChirico deleted the i18n-r-fragments branch September 24, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants