Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guidance for patch releases #5989

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Update guidance for patch releases #5989

merged 4 commits into from
Jul 13, 2024

Conversation

MichaelChirico
Copy link
Member

Follows discussion in #5963

@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (815e054) to head (57eecb7).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5989   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          80       80           
  Lines       14861    14861           
=======================================
  Hits        14488    14488           
  Misses        373      373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ben-schwen
ben-schwen reviewed Mar 8, 2024
View reviewed changes
.dev/CRAN_Release.cmd Outdated Show resolved Hide resolved
ben-schwen
ben-schwen reviewed Mar 8, 2024
View reviewed changes
.dev/CRAN_Release.cmd Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico commented Mar 9, 2024
View reviewed changes
.dev/CRAN_Release.cmd Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico commented Mar 9, 2024
View reviewed changes
.dev/CRAN_Release.cmd Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Member Author

@TysonStanley how is this looking after the last release?

@jangorecki jangorecki removed their request for review April 9, 2024 20:05
@MichaelChirico
Copy link
Member Author

Friendly ping @TysonStanley :)

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Jul 10, 2024
@MichaelChirico MichaelChirico mentioned this pull request Jul 13, 2024
Merged
TysonStanley
TysonStanley approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@TysonStanley TysonStanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the new section. This is helpful to lay out more fully.

@TysonStanley TysonStanley mentioned this pull request Jul 13, 2024
Closed
@MichaelChirico MichaelChirico merged commit 4827b67 into master Jul 13, 2024
3 checks passed
@MichaelChirico MichaelChirico deleted the patch-procedure branch July 13, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-schwen ben-schwen ben-schwen left review comments

@TysonStanley TysonStanley TysonStanley approved these changes

Assignees

@TysonStanley TysonStanley

Labels
None yet
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelChirico @TysonStanley @ben-schwen